Closed
Bug 1157303
Opened 10 years ago
Closed 10 years ago
Display and handle notifications for received tabs
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fxios | + | --- |
People
(Reporter: rnewman, Assigned: fluffyemily)
References
(Blocks 1 open bug)
Details
(Whiteboard: noteworthy)
Attachments
(5 files)
I'm going to land this half-baked: we'll show a notification, but it's not localized, has no icon, and doesn't do anything when tapped.
This bug is to fill in the rest: you get a URL and a title, go do something with it.
Reporter | ||
Updated•10 years ago
|
tracking-fennec: --- → +
Reporter | ||
Comment 1•10 years ago
|
||
See BrowserProfileSyncDelegate in Profile.swift.
Assignee: nobody → etoop
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
OK, so what _should_ it do when tapped?
And what should the icon be?
And is there anything else this should do?
And if you don't know, who's should I ask?
Flags: needinfo?(rnewman)
Reporter | ||
Comment 3•10 years ago
|
||
When the notification is tapped, we should load the provided URL in a new tab in Firefox.
The icon should be a platform-suitable rendition of the Firefox icon. 302 :tecgirl for that, and any questions about the UX.
Any strings should be localized, and ideally we can present both title (if known) and URL, but beyond that, it doesn't need to do anything else at this point.
(Eventually we might want to go straight into our external app handler to avoid flicking through the browser UI to launch a map URL or open a tweet, but we can leave that until our external app stuff is stable.)
Flags: needinfo?(rnewman)
Updated•10 years ago
|
tracking-fxios:
--- → +
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8623183 -
Flags: review?(sarentz)
Comment 5•10 years ago
|
||
Comment on attachment 8623183 [details] [review]
Pull request
Looks good! Just a few small comments in the PR.
Attachment #8623183 -
Flags: review?(sarentz) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
Assignee | ||
Comment 9•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
tracking-fennec: + → ---
Whiteboard: noteworthy
You need to log in
before you can comment on or make changes to this bug.
Description
•